Merged
Conversation
dimas-b
requested review from
RussellSpitzer,
ashvina,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
After running `./polaris ...`: ``` $ git st On branch main Your branch is up to date with 'origin/main'. Untracked files: (use "git add <file>..." to include in what will be committed) poetry.lock polaris-venv/ pyproject.toml ```
flyrain
approved these changes
Sep 3, 2024
eric-maynard
approved these changes
Sep 4, 2024
Contributor
Author
|
@snazy : Do you think we could merge this? |
snazy
reviewed
Sep 6, 2024
.gitignore
Outdated
| # Python stuff | ||
| poetry.lock | ||
| polaris-venv/ | ||
| pyproject.toml |
Member
There was a problem hiding this comment.
Hm - looks like ./regtests/client/python/pyproject.toml and ./regtests/client/python/poetry.lock are in versioned Git though.
Contributor
Author
There was a problem hiding this comment.
but they are not covered by this exclusion 🤔 Do you mean we should exclude those files or commit poetry.lock?
Member
There was a problem hiding this comment.
They would be. It's just that those files are already managed by Git.
Maybe you meant
/poetry.lock
/pyproject.toml
?
Contributor
Author
There was a problem hiding this comment.
/p/polaris (git-ignore|✚1) $ git status
On branch git-ignore
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: regtests/client/python/poetry.lock
... but it's a good point in general. I've added leading slashes to avoid ambiguity.
snazy
approved these changes
Sep 9, 2024
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After running
./polaris ...:Description
Excluding python-related auxiliary files from source control.